-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hive metastore catalog support (part 1/2) #237
Merged
Merged
Changes from 13 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
8723ed7
fmt members
mlanhenke 342b686
setup basic test-infra for hms-catalog
mlanhenke d8ccce1
add license
mlanhenke 910d848
add hms create_namespace
mlanhenke 315ddde
add hms get_namespace
mlanhenke 05886bd
fix: typo
mlanhenke ada8193
add hms namespace_exists and drop_namespace
mlanhenke 00c720b
add hms update_namespace
mlanhenke 1b98f88
move fns into HmsCatalog
mlanhenke f82fa5d
use `expose` in docker-compose
mlanhenke 10b53ba
add hms list_tables
mlanhenke b35916c
fix: clippy
mlanhenke cfcbc17
fix: cargo sort
mlanhenke 2e320fe
fix: cargo workspace
marvinlanhenke ae03c85
move fns into utils + add constants
marvinlanhenke 17cb904
include database name in error msg
marvinlanhenke 3aef54a
add pilota to cargo workspace
marvinlanhenke 1660f3b
add minio version
marvinlanhenke 0716baf
Merge branch 'main' into hms
marvinlanhenke a33132e
change visibility to pub(crate); return namespace from conversion fn
marvinlanhenke 153bb6f
add minio version in rest-catalog docker-compose
marvinlanhenke 2b80a4b
fix: hms test docker infrastructure
marvinlanhenke bde3c98
add version to minio/mc
marvinlanhenke 8375c75
fix: license header
marvinlanhenke 7dc7adb
fix: core-site
marvinlanhenke File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -33,5 +33,12 @@ anyhow = { workspace = true } | |
async-trait = { workspace = true } | ||
hive_metastore = { workspace = true } | ||
iceberg = { workspace = true } | ||
log = "0.4.20" | ||
pilota = "0.10.0" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ditto There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. thanks - changed it |
||
typed-builder = { workspace = true } | ||
volo-thrift = { workspace = true } | ||
|
||
[dev-dependencies] | ||
iceberg_test_utils = { path = "../../test_utils", features = ["tests"] } | ||
port_scanner = { workspace = true } | ||
tokio = { workspace = true } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's better to add in workspace instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you - I changed it.