feat: Add transform #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fokko
reviewed
Aug 9, 2023
liurenjie1024
force-pushed
the
renjie/transform
branch
from
90aca80 to
9a4cbd1
Compare
liurenjie1024
force-pushed
the
renjie/transform
branch
from
9a4cbd1 to
aad52f2
Compare
|
CC @Fokko Any other comments? |
Fokko
approved these changes
Aug 10, 2023
There was a problem hiding this comment.
@liurenjie1024 No this looks good. The next step would be to implement the actual functions, hash, truncate, etc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr doesn't contains actual transform function implementation, since it depends on #20 But it introduces basic transform definition.