Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add doc test action #44

Merged
merged 1 commit into from
Aug 30, 2023
Merged

fix: Add doc test action #44

merged 1 commit into from
Aug 30, 2023

Conversation

liurenjie1024
Copy link
Contributor

Close #43 .

@liurenjie1024
Copy link
Contributor Author

cc @Xuanwo @JanKaul @Fokko @nastra PTAL
A small fix.

JanKaul
JanKaul approved these changes Aug 29, 2023
View reviewed changes
Copy link
Collaborator

@JanKaul JanKaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you!

@Fokko Fokko merged commit 79d37a0 into apache:main Aug 30, 2023
@liurenjie1024 liurenjie1024 deleted the renjie/issue-43 branch August 30, 2023 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JanKaul JanKaul JanKaul approved these changes

@Fokko Fokko Fokko approved these changes

@Xuanwo Xuanwo Awaiting requested review from Xuanwo

@nastra nastra Awaiting requested review from nastra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: ci doesn't not run doc test.
3 participants
@liurenjie1024 @Fokko @JanKaul