feat(datafusion): Support pushdown more datafusion exprs to Iceberg #649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FANNG1
changed the title
FANNG1
changed the title
|
@liurenjie1024 @Xuanwo @sdd @a-agmon please help to review when you are free, thanks |
FANNG1
changed the title
a-agmon
reviewed
Sep 29, 2024
| TransformedResult::Predicate(Predicate::Binary(BinaryExpression::new(op, r, d))) | ||
| } | ||
|
|
||
| fn reserve_predicate_operator(op: PredicateOperator) -> PredicateOperator { |
There was a problem hiding this comment.
I think you meant reverse in the function name rather than reserve?
There was a problem hiding this comment.
yes, thanks for pointing, updated
shaeqahmed
pushed a commit
to matanolabs/iceberg-rust
that referenced
this pull request
Dec 9, 2024
…pache#649) * suppport more datafusion predict * add it * reverse op
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #644
DataFusion expressions and Iceberg predicates do not have a one-to-one correspondence.
Exprin DataFusion, whereas they are merely components of predicates in Iceberg.AndandOrare operators in DataFusion, but they are treated as predicates in Iceberg.This disparity complicates the transformation process when using
TreeNode. To address this, I also refactored the code to simplify it.