fix: TableUpdate Snapshot deserialization for v1 #656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rest-spec specifies sequence-number as optional for TableUpdates:
https://github.com/apache/iceberg/blob/09c737656d316ab6172e0d5ee6920869237e6fd1/open-api/rest-catalog-open-api.yaml#L2319-L2326
In the previous deserialization of updates using
_serde::SnapshotV2sequence-number is required.This PR adds a separate deserialization function for catalogs that follows the REST spec.
I got errors from starrocks when writing V1 tables.