Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Derive PartialEq for FileScanTask #660

Merged
merged 2 commits into from
Oct 12, 2024

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Oct 9, 2024

This PR derives PartialEq for FileScanTask so users can compare them while needed.

@Xuanwo Xuanwo requested a review from liurenjie1024 October 9, 2024 08:50
@sdd
Copy link
Contributor

sdd commented Oct 11, 2024

Looks like you just need a rebase on this to get your Arrow 53.1 fix in :-)

@Xuanwo
Copy link
Member Author

Xuanwo commented Oct 11, 2024

Thank you, @sdd, for the reminder. It's weird that GitHub doesn't provide an update branches button for me.

Copy link
Contributor

@liurenjie1024 liurenjie1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @Xuanwo for this pr!

@liurenjie1024 liurenjie1024 merged commit 97fc01d into apache:main Oct 12, 2024
16 checks passed
@Xuanwo Xuanwo deleted the file-scan-partial-eq branch October 12, 2024 07:30
shaeqahmed pushed a commit to matanolabs/iceberg-rust that referenced this pull request Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants