name mapping serde #740
Merged
name mapping serde #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barronw
commented
Nov 28, 2024
| #[serde(rename_all = "kebab-case")] | ||
| pub struct MappedField { | ||
| #[serde(skip_serializing_if = "Option::is_none")] | ||
| pub field_id: Option<i32>, |
There was a problem hiding this comment.
Good catch, I noticed that field-id is optional in Java as well. Created an issue on PyIceberg: apache/iceberg-python#1420
| @@ -20,6 +20,7 @@ | |||
| mod datatypes; | |||
| mod manifest; | |||
| mod manifest_list; | |||
| mod name_mapping; | |||
There was a problem hiding this comment.
Please let me know if I should also expose the name mapping in TableMetadata and Table (as pyiceberg does).
There was a problem hiding this comment.
I think we can add them later on 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #723.