Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Migrate from tempdir to tempfile crate #91

Merged
merged 1 commit into from
Nov 15, 2023
Merged

fix: Migrate from tempdir to tempfile crate #91

merged 1 commit into from
Nov 15, 2023

Conversation

cdaudt
Copy link
Contributor

@cdaudt cdaudt commented Nov 3, 2023

tempdir is obsolete and relies on remove_dir_all 0.5.3 which has a security vulnerability. Migrate to using tempfile crate instead. References:

liurenjie1024
liurenjie1024 approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@liurenjie1024 liurenjie1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Xuanwo
Xuanwo approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Fokko
Fokko approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch @cdaudt, and thanks for fixing this. Can you resolve the conflicts?

@cdaudt
fix: Migrate from tempdir to tempfile crate
68913bb 
tempdir is obsolete and relies on remove_dir_all 0.5.3 which has a
security vulnerability. Migrate to using tempfile crate instead.
References:
- [RUSTSEC-2018-0017](https://rustsec.org/advisories/RUSTSEC-2018-0017)
- [RUSTSEC-2013-0018](https://rustsec.org/advisories/RUSTSEC-2023-0018)
@cdaudt cdaudt force-pushed the fix/tempdir-dependency branch from 8336ed9 to 68913bb Compare November 13, 2023 22:04
@cdaudt
Copy link
Contributor Author

cdaudt commented Nov 13, 2023

Great catch @cdaudt, and thanks for fixing this. Can you resolve the conflicts?

done

@liurenjie1024
Copy link
Contributor

CC @Fokko

@Fokko Fokko merged commit 3b5c35e into apache:main Nov 15, 2023
6 checks passed
@Fokko
Copy link
Contributor

Fokko commented Nov 15, 2023

Thanks @cdaudt for fixing this, and @liurenjie1024 & @Xuanwo for the review 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@liurenjie1024 liurenjie1024 liurenjie1024 approved these changes

@Fokko Fokko Fokko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cdaudt @liurenjie1024 @Fokko @Xuanwo