Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chroes:Manage dependencies using workspace. #93

Merged
merged 1 commit into from
Nov 13, 2023
Merged

chroes:Manage dependencies using workspace. #93

merged 1 commit into from
Nov 13, 2023

Conversation

my-vegetable-has-exploded
Copy link
Contributor

close #24

liurenjie1024
liurenjie1024 approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@liurenjie1024 liurenjie1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Fokko
Fokko approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @my-vegetable-has-exploded, and thanks for the review @liurenjie1024

@Fokko Fokko merged commit 358187f into apache:main Nov 13, 2023
6 checks passed
@my-vegetable-has-exploded
Copy link
Contributor Author

thanks

@my-vegetable-has-exploded my-vegetable-has-exploded deleted the cargo-workspace branch November 13, 2023 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liurenjie1024 liurenjie1024 liurenjie1024 approved these changes

@Fokko Fokko Fokko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Manage dependencies using workspace.
3 participants
@my-vegetable-has-exploded @Fokko @liurenjie1024