Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iceberg-mr: Switch class level parameterized tests to Junit5 #9269

Closed
lschetanrao opened this issue Dec 11, 2023 · 2 comments
Closed

iceberg-mr: Switch class level parameterized tests to Junit5 #9269

lschetanrao opened this issue Dec 11, 2023 · 2 comments
Assignees
@lisirrx
Labels
beginner Issues for apache iceberg beginners, enjoy to contribute ! good first issue Good for newcomers

Comments

@lschetanrao
Copy link
Contributor

Feature Request / Improvement

Once #9161 is merged, we should migrate class level parameterized tests to Junit5.

Query engine

None
@nastra nastra added good first issue Good for newcomers beginner Issues for apache iceberg beginners, enjoy to contribute ! labels Dec 11, 2023
@lisirrx
Copy link
Contributor

lisirrx commented Feb 4, 2024

hi @nastra , could you please assign this task to me?

lisirrx added a commit to lisirrx/iceberg that referenced this issue Feb 11, 2024
@lisirrx
fix apache#9269 Switch class level parameterized for mr
f6bc35a
@lisirrx lisirrx mentioned this issue Feb 11, 2024
Merged
lisirrx added a commit to lisirrx/iceberg that referenced this issue Feb 13, 2024
@lisirrx
fix apache#9269 Switch class level parameterized for mr
0058718
lisirrx added a commit to lisirrx/iceberg that referenced this issue Feb 13, 2024
@lisirrx
fix apache#9269 Switch class level parameterized for mr
3335776
@nastra
Copy link
Contributor

nastra commented Feb 13, 2024

fixed by #9711

@nastra nastra closed this as completed Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lisirrx lisirrx

Labels
beginner Issues for apache iceberg beginners, enjoy to contribute ! good first issue Good for newcomers
Projects
JUnit4 to JUnit5 Migration
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nastra @lisirrx @lschetanrao