Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Use encoding/decoding methods for namespaces and deprecate Splitter/Joiner #10858

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

nastra
Copy link
Contributor

@nastra nastra commented Aug 2, 2024

We want to eventually make the namespace separator configurable. In order to do that, all the encoding / decoding should go through RestUtil.encodeNamespace and RestUtil.decodeNamespacerather than using the Splitter / Joiner

@nastra nastra requested a review from amogh-jahagirdar August 2, 2024 14:30
@github-actions github-actions bot added the core label Aug 2, 2024
@nastra nastra requested review from findepi and Fokko August 2, 2024 14:52
@nastra
Copy link
Contributor Author

nastra commented Aug 5, 2024

thanks for the review @Fokko

@nastra nastra merged commit 5fc1413 into apache:main Aug 5, 2024
44 checks passed
@nastra nastra deleted the use-encode-decode-namespace-methods branch August 5, 2024 12:35
@mayankvadariya
Copy link

This change seem to have affected nested namespace support.

With encoded params, queryParams are further encoded in URIBuilder.

params.forEach(builder::addParameter);

buildUri(path, queryParams) generates following output

before
for queryParams containing parent -> level1�level2
http://localhost:32792/api/catalog/v1/namespaces?parent=level1%1Flevel2&pageToken=

after
for queryParams containing parent -> level1%1Flevel2
http://localhost:32794/api/catalog/v1/namespaces?parent=level1%251Flevel2&pageToken=

@nastra please advise if we need to revert this change.

@nastra
Copy link
Contributor Author

nastra commented Nov 13, 2024

@mayankvadariya can you please open a separate issue for this? Also do you have a reproducible example where this fails? I'm guessing this is in the Trino PR you linked?

@mayankvadariya
Copy link

hi @nastra, I've created #11539 with reproduction steps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants