-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenAPI: Add planning-mode to loadTable response #11156
Conversation
@@ -3138,6 +3149,8 @@ components: | |||
description: May be null if the table is staged as part of a transaction | |||
metadata: | |||
$ref: '#/components/schemas/TableMetadata' | |||
planning-mode: | |||
$ref: '#/components/schemas/PlanningMode' | |||
config: | |||
type: object |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like from the sync meeting, we are saying the planning mode should be in config, something like:
config:
type: object
properties:
planning-mode:
$ref: '#/components/schemas/PlanningMode'
additionalProperties:
type: string
Is this the right understanding?
PlanningMode: | ||
description: Indicates to clients if a service supports server-side planning for a given table. | ||
type: string | ||
enum: ["unsupported", "supported", "required"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
default unsupported?
Was wondering if I could get your thoughts on this @rdblue @danielcweeks @amogh-jahagirdar @singhpk234 |
@amogh-jahagirdar I was wondering if we should tag this on the milestone board for 1.7.0 as it relates to the impl pr #11180 |
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions. |
This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. |
Recently in the iceberg community we landed a new set of scan planning apis within the rest spec #9695.
The following spec change in this pr aims to provide a way for client to know when to call the new scan planning apis. Within a rest catalog, services may choose to support scan planning for all tables or for a subset of tables. In this case we think it would be best to make the change in the
loadTable
response to indicate if scan planning is supported for the table.cc @rdblue @danielcweeks @jackye1995 @amogh-jahagirdar @singhpk234 @geruh