Spark 3.5: Make ColumnVectorWithFilter generic and refactor batch load #12056
+88
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aokolnychyi
force-pushed
the
column-vector-with-filter
branch
from
497b6a5 to
85419ce
Compare
aokolnychyi
commented
Jan 23, 2025
| } | ||
|
|
||
| @Override | ||
| public ColumnarArray getArray(int rowId) { | ||
| if (isNullAt(rowId)) { |
There was a problem hiding this comment.
We no longer need this as we wrap valid ColumnVector implementations now.
|
@huaxingao, could you check this one? I've been meaning to refactor our |
huaxingao
approved these changes
Jan 23, 2025
|
Thanks for the refactor! The code is much cleaner now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
ColumnVectorWithFiltergeneric by wrapping arbitraryColumnVectorimplementations and refactors logic for loading columnar batches.