Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove slf4j-api reference in LICENSE (#12052) #12068

Open
wants to merge 1 commit into
base: 1.7.x
Choose a base branch
from

Conversation

Fokko
Copy link
Contributor

@Fokko Fokko commented Jan 23, 2025

Work by @jbonofre, let's include this in 1.7.2 as well:

I've checked out the branch, and it is also excluded from the JAR on the 1.7.x branch:

➜  azure find . | grep -i slf4j
./org/apache/iceberg/azure/shaded/io/netty/util/internal/logging/LocationAwareSlf4JLogger.class
./org/apache/iceberg/azure/shaded/io/netty/util/internal/logging/Slf4JLoggerFactory$NopInstanceHolder.class
./org/apache/iceberg/azure/shaded/io/netty/util/internal/logging/Slf4JLoggerFactory.class
./org/apache/iceberg/azure/shaded/io/netty/util/internal/logging/Slf4JLogger.class
./reactor/util/Loggers$Slf4JLoggerFactory.class
./reactor/util/Loggers$Slf4JLogger.class
➜  gcp find . | grep -i slf4j                                                                               
./io/grpc/netty/shaded/io/netty/util/internal/logging/LocationAwareSlf4JLogger.class
./io/grpc/netty/shaded/io/netty/util/internal/logging/Slf4JLoggerFactory$NopInstanceHolder.class
./io/grpc/netty/shaded/io/netty/util/internal/logging/Slf4JLoggerFactory.class
./io/grpc/netty/shaded/io/netty/util/internal/logging/Slf4JLogger.class
➜  aws find . | grep -i slf4j                     
./org/apache/iceberg/aws/shaded/io/netty/util/internal/logging/LocationAwareSlf4JLogger.class
./org/apache/iceberg/aws/shaded/io/netty/util/internal/logging/Slf4JLoggerFactory$NopInstanceHolder.class
./org/apache/iceberg/aws/shaded/io/netty/util/internal/logging/Slf4JLoggerFactory.class
./org/apache/iceberg/aws/shaded/io/netty/util/internal/logging/Slf4JLogger.class

Copy link
Member

@jbonofre jbonofre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Fokko !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants