Fix NOTICE and LICENSE in the aws-bundle jar #12142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@amogh-jahagirdar @rdblue @Fokko This is the first PR extracted from #12095 |
jbonofre
changed the title
jbonofre
changed the title
rdblue
reviewed
Jan 31, 2025
rdblue
reviewed
Jan 31, 2025
| Project URL: https://netty.io/ | ||
| License: Apache License, Version 2.0 - https://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| -------------------------------------------------------------------------------- | ||
|
|
||
| Group: io.netty Name: netty-transport-native-unix-common Version: 4.1.112.Final | ||
| Group: io.netty Name: netty-transport-native-unix-common Version: 4.1.115.Final |
There was a problem hiding this comment.
Not a blocker for this, but we should collapse all of these in future versions. This doesn't need to be at the Jar granularity.
There was a problem hiding this comment.
Agree, I'm using the same format to facilitate the review. I propose to do that after the releases.
rdblue
reviewed
Jan 31, 2025
rdblue
approved these changes
Jan 31, 2025
jbonofre
force-pushed
the
notice-fix-aws-bundle
branch
from
c4cc25f to
72606d5
Compare
jbonofre
force-pushed
the
notice-fix-aws-bundle
branch
from
72606d5 to
8660f5b
Compare
amogh-jahagirdar
approved these changes
Jan 31, 2025
There was a problem hiding this comment.
Thank you @jbonofre for your work here, I know all of this is quite tedious but it's really important and appreciated!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes:
LICENSEandNOTICENOTICEwithnetty