Fix NOTICE and LICENSE in the azure-bundle jar #12143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@amogh-jahagirdar @rdblue @Fokko This is the PR about |
jbonofre
changed the title
rdblue
reviewed
Jan 31, 2025
|
|
||
| -------------------------------------------------------------------------------- | ||
|
|
||
| NOTICE for Group: io.netty Name: netty-buffer Version: 4.1.115.Final |
There was a problem hiding this comment.
Minor: It would be better to just state that this is the NOTICE for Netty, not each artifact individually.
There was a problem hiding this comment.
I'm using the same formatting as for other dependencies. Do you want me to change that now or do we wait after the releases ?
rdblue
reviewed
Jan 31, 2025
rdblue
approved these changes
Jan 31, 2025
Comment on lines
-498
to
-500
| Group: org.codehaus.woodstox Name: stax2-api Version: 4.2.1 | ||
| Project URL: http://github.com/FasterXML/stax2-api | ||
| License: The BSD License - http://www.opensource.org/licenses/bsd-license.php |
There was a problem hiding this comment.
Double checking this is no longer in the bundle
There was a problem hiding this comment.
Confirmed. We can remove ths.
jbonofre
force-pushed
the
notice-fix-azure-bundle
branch
from
e01a96c to
e7f4896
Compare
amogh-jahagirdar
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes
LICENSEandNOTICEin the azure-bundle jar with:jackson-dataformat-xmlas it's not in the runtime classpath and the jarwoodstox-coreas it's not in the runtime classpath and the jarNOTICEcontent in azure-bundleNOTICE