Fix NOTICE and LICENSE in the flink-runtime jar #12145
Conversation
|
@amogh-jahagirdar @Fokko @rdblue this is the change for flink-runtime extracted from #12095 |
flink/v1.20/flink-runtime/NOTICE
Outdated
| | * GNU General Public License, Version 2 with the GNU Classpath Exception | ||
| | |
There was a problem hiding this comment.
NB: I checked on Nessie "license report" (https://github.com/projectnessie/nessie/releases/download/nessie-0.102.2/nessie-aggregated-license-report-0.102.2.zip):
- It's GPL with GNU Classpath Exception. It means that we can "extend" the classpath with Nessie, but problematic to bundle in our jar.
- It's dual licenses (GPL + CDDL or GPL + EPL)
There was a problem hiding this comment.
GPL, even with the classpath exception, is a Category X license: https://www.apache.org/legal/resolved.html
We can't include it in a release. The Nessie docs need to be updated to remove this before we can ship a release with Nessie.
There was a problem hiding this comment.
The Nessie team informed me that they checked and cleanup their NOTICE (no actual GPL code copied): https://github.com/projectnessie/nessie/blob/main/NOTICE
They also checked the binary distribution and no GPL dependency bundled.
They said they gonna do a new release. I'm already updating the NOTICE here.
There was a problem hiding this comment.
Thanks @jbonofre for checking with them!
There was a problem hiding this comment.
We updated to Nessie 0.102.4 that fixed their NOTICE in regards of GPL.
There was a problem hiding this comment.
I think that this is still too unclear to include in Iceberg. The Nessie binary NOTICE file that applies to Jars (binaries) still includes mention of GPL code. The fixed Nessie NOTICE states that it applies to Nessie source code so this is still not clear from the documentation.
There was a problem hiding this comment.
I've updated the Nessie NOTICE with the 0.102.5 release.
jbonofre
force-pushed
the
notice-fix-flink-runtime
branch
2 times, most recently
from
14db2b3 to
26c76b7
Compare
There was a problem hiding this comment.
Thanks @jbonofre , I think we're incorrectly removing stuff that's still in the bundle. Left comments
jbonofre
force-pushed
the
notice-fix-flink-runtime
branch
from
26c76b7 to
769739a
Compare
There was a problem hiding this comment.
Are we sure that we capture everthing? Unzipping the JAR shows more dependencies, such as datasketches:
unzip iceberg-flink-runtime-1.20-1.8.0-SNAPSHOT.jar
➜ libs git:(main) ls -lah org/apache/datasketches | head
total 8
drwxr-xr-x 22 fokko.driesprong staff 704B Feb 1 1980 .
drwxr-xr-x 5 fokko.driesprong staff 160B Feb 1 1980 ..
drwxr-xr-x 22 fokko.driesprong staff 704B Feb 1 1980 common
drwxr-xr-x 29 fokko.driesprong staff 928B Feb 1 1980 cpc
drwxr-xr-x 6 fokko.driesprong staff 192B Feb 1 1980 fdt
drwxr-xr-x 4 fokko.driesprong staff 128B Feb 1 1980 filters
drwxr-xr-x 16 fokko.driesprong staff 512B Feb 1 1980 frequencies
drwxr-xr-x 7 fokko.driesprong staff 224B Feb 1 1980 hash
drwxr-xr-x 47 fokko.driesprong staff 1.5K Feb 1 1980 hll
We discussed about not including all ASF projects (not required). |
In the first version of the PR, I documented datasketches. But discussing with @rdblue it's not necessary to include the ASF projects. |
jbonofre
force-pushed
the
notice-fix-flink-runtime
branch
2 times, most recently
from
d9a5e7f to
79e27fa
Compare
jbonofre
force-pushed
the
notice-fix-flink-runtime
branch
from
79e27fa to
c3a54e0
Compare
This is a proposal including:
LICENSEas it's not in the jar or the runtime classpathLICENSEas it's not in the jar or the runtime classpathLICENSE(NOTICEshould go inNOTICE)LICENSE(it's in the jar)LICENSE(it's in the jar)LICENSE(it's in the jar)LICENSE(it's in the jar)NOTICE(with the correct Nessie version)NOTICE