Core: Use unknown report type for forward-compatibility #7145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nastra
commented
Mar 20, 2023
| if (report instanceof ScanReport) { | ||
| reportType = ReportType.SCAN_REPORT; | ||
| } else if (report instanceof CommitReport) { | ||
| reportType = ReportType.COMMIT_REPORT; | ||
| } | ||
|
|
||
| Preconditions.checkArgument( | ||
| null != reportType, "Unsupported report type: %s", report.getClass().getName()); | ||
|
|
||
| return ImmutableReportMetricsRequest.builder().reportType(reportType).report(report).build(); |
There was a problem hiding this comment.
we don't fallback to returning ReportMetricsRequest unknown() because should prefer the report that was passed in to this method in L57
There was a problem hiding this comment.
Is this for cases where an unknown metrics report is passed by a user rather than by Iceberg? I guess that makes sense, but I wouldn't expect it to happen.
There was a problem hiding this comment.
I wouldn't expect it to happen either, but I think it's more correct to pass-through whatever the report was in the first place (rather than defaulting to an unknown impl).
rdblue
approved these changes
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.