-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API: implement types timestamp_ns and timestamptz_ns #9008
Merged
Merged
Changes from all commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
0e098f0
API: implement types timestamp_ns and timestamptz_ns
jacobmarble b283a5a
Redo as separate type
epgif a114044
Try to hew closer to the original satisfiesOrderOf logic.
epgif 0ebdf9f
Test that Avro produces a value within 1 micro
epgif bea3487
address most comments
epgif 753aed5
Bucket timestamp and timestamp_ns the same.
epgif 19605d6
Fix bug caught by TestPartitionSpecParser#testTransforms .
epgif d0b4627
address review comments
epgif 2f71da9
address style improvements
epgif c3c1288
test DateTimeUtil.convertNanos on negative input
epgif ec01d68
use Math.toIntExact in Timestamps NANOS conversion
epgif 08e123c
Merge branch 'main' into jgm-timestamp-nanos-api
epgif eb5e382
address review comments
epgif 421ed86
Adjust tests as requested.
epgif d7a1326
add nanosecond tests to TestTimestamps
jacobmarble 068b18b
add timestamptz and timestampns_tz to fromPrimitiveString test
jacobmarble 269b3e9
correct TestYears - was testing days
jacobmarble 8462374
test Avro timestamp conversion precisely
jacobmarble 16319d8
Add requested additional tests.
epgif e38f68a
Remove redundant and erroneous tests.
epgif 654fc61
Merge remote-tracking branch 'jacobmarble/jgm-timestamp-nanos-api' in…
epgif d34daad
Update TestBucketing as requested.
epgif 42ca8a4
Convert long to TimestampLiteral and then that to TimestampNanoLiteral.
epgif 0cbdeb8
Use DateTimeUtil conversion instead of /.
rdblue 48626e5
Update Literals to use DateTimeUtil, add new tests.
rdblue 743e872
Fix test for DateTimeUtil.isoTimestampToNanos.
rdblue dedeb19
Fix TestDateTimeUtil and add test cases.
rdblue c9f4273
Simplify Timestamps transform get.
rdblue 97489ab
Remove ChronoUnit wrapper enum.
rdblue 8c3cc67
Restore Timestamps as enum and simplify boilerplate.
rdblue 6f25c99
Minor fix to bucket transform.
rdblue f006cb2
Fix style
rdblue 066c955
Fix typos in TestTimestamps.
rdblue 4d77202
Add a comment to clarify conversion test.
rdblue 9a3d16f
Split timestamp and timestamp_ns comparator test cases.
rdblue 274de56
Fix spec update to specify microsecond hashing.
rdblue 20e7085
Merge pull request #1 from rdblue/jgm-timestamp-nanos-api
jacobmarble 0bbd3d6
Run :iceberg-api:spotlessApply
epgif 58f11a3
fix testTimestampWithZoneHumanString
epgif 8ea5777
Prevent creating table metadata with nanosecond timestamps before v3.
rdblue 1321952
Merge pull request #2 from rdblue/jgm-timestamp-nanos-api
47d4b64
fix merge conflict
jacobmarble File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm. Now that I'm thinking about this more, we may want to accumulate a full set of problems and then show them in one message. That can be done as a follow-up though.