Core: Mark 502 and 504 statuses as retryable to the REST exponential retry strategy #9885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amogh-jahagirdar
changed the title
nastra
approved these changes
Mar 7, 2024
|
Thanks for the review @nastra ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bad gateway or gateway timeouts should be able to be safely retried. A bad gateway could be caused by a load balancer or proxy between the client and the actual server, when there's some network partition between the LB and server. A retry in this case could route the request to another server.
A gateway timeout could occur when the LB/proxy is waiting for a response from the actual server, but it takes too long. in this case a retry could be performed again to increase the chance of hitting a more available server.