Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default System segment message expiry not respected #1536

Closed
FireMasterK opened this issue Feb 15, 2025 · 0 comments · Fixed by #1545
Closed

Default System segment message expiry not respected #1536

FireMasterK opened this issue Feb 15, 2025 · 0 comments · Fixed by #1545
Labels
bug Something isn't working

Comments

@FireMasterK
Copy link

I'm running iggy like this in docker-compose:

  iggy-server:
    image: iggyrs/iggy:0.4.203
    container_name: iggy-server
    ports:
      - "127.0.0.1:8090:8090"
      - "100.107.7.89:8090:8090"
      - "127.0.0.1:3000:3000"
    environment:
      IGGY_SYSTEM_MESSAGE_DEDUPLICATION_ENABLED: "true"
      IGGY_SYSTEM_CACHE_SIZE: "512MB"
      IGGY_SYSTEM_SEGMENT_MESSAGE_EXPIRY: "5m"
      IGGY_DATA_MAINTENANCE_MESSAGES_CLEANER_ENABLED: "true"
      IGGY_SYSTEM_CACHE_ENABLED: "false"
    restart: unless-stopped
    volumes:
      - iggy-server:/iggy/local_data

When I run these:

docker exec -it iggy-server iggy --username iggy --password iggy stream create exchange-data
docker exec -it iggy-server iggy --username iggy --password iggy topic create exchange-data stocks-prices 1 none

The message expiry is still unlimited:

docker exec -it iggy-server iggy --username iggy --password iggy topic l 1
@hubcio hubcio added the bug Something isn't working label Feb 15, 2025
hubcio added a commit that referenced this issue Feb 17, 2025
This commit updates the CLI and associated tests to use "server_default"
as the default value for max topic size and message expiry time, instead
of "unlimited". This change ensures that the CLI uses the server's
default configuration when parameters are not explicitly specified by
the user. Additionally, the commit modifies the display and parsing
logic for `IggyExpiry` to use "never_expire" instead of "none" for
clarity. The tests have been updated to reflect these changes, ensuring
that the new defaults are correctly applied and tested.

This closes #1536.
hubcio added a commit that referenced this issue Feb 17, 2025
This commit updates the CLI and associated tests to use "server_default"
as the default value for max topic size and message expiry time, instead
of "unlimited". This change ensures that the CLI uses the server's
default configuration when parameters are not explicitly specified by
the user. Additionally, the commit modifies the display and parsing
logic for `IggyExpiry` to use "never_expire" instead of "none" for
clarity. The tests have been updated to reflect these changes, ensuring
that the new defaults are correctly applied and tested.

This closes #1536.
hubcio added a commit that referenced this issue Feb 17, 2025
This commit updates the CLI and associated tests to use "server_default"
as the default value for max topic size and message expiry time, instead
of "unlimited". This change ensures that the CLI uses the server's
default configuration when parameters are not explicitly specified by
the user. Additionally, the commit modifies the display and parsing
logic for `IggyExpiry` to use "never_expire" instead of "none" for
clarity. The tests have been updated to reflect these changes, ensuring
that the new defaults are correctly applied and tested.

This closes #1536.
hubcio added a commit that referenced this issue Feb 17, 2025
This commit updates the CLI and associated tests to use "server_default"
as the default value for max topic size and message expiry time, instead
of "unlimited". This change ensures that the CLI uses the server's
default configuration when parameters are not explicitly specified by
the user. Additionally, the commit modifies the display and parsing
logic for `IggyExpiry` to use "never_expire" instead of "none" for
clarity. The tests have been updated to reflect these changes, ensuring
that the new defaults are correctly applied and tested.

This closes #1536.
hubcio added a commit that referenced this issue Feb 17, 2025
This commit updates the CLI and associated tests to use "server_default"
as the default value for max topic size and message expiry time, instead
of "unlimited". This change ensures that the CLI uses the server's
default configuration when parameters are not explicitly specified by
the user. Additionally, the commit modifies the display and parsing
logic for `IggyExpiry` to use "never_expire" instead of "none" for
clarity. The tests have been updated to reflect these changes, ensuring
that the new defaults are correctly applied and tested.

This closes #1536.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants