-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default System segment message expiry not respected #1536
Labels
bug
Something isn't working
Comments
hubcio
added a commit
that referenced
this issue
Feb 17, 2025
This commit updates the CLI and associated tests to use "server_default" as the default value for max topic size and message expiry time, instead of "unlimited". This change ensures that the CLI uses the server's default configuration when parameters are not explicitly specified by the user. Additionally, the commit modifies the display and parsing logic for `IggyExpiry` to use "never_expire" instead of "none" for clarity. The tests have been updated to reflect these changes, ensuring that the new defaults are correctly applied and tested. This closes #1536.
hubcio
added a commit
that referenced
this issue
Feb 17, 2025
This commit updates the CLI and associated tests to use "server_default" as the default value for max topic size and message expiry time, instead of "unlimited". This change ensures that the CLI uses the server's default configuration when parameters are not explicitly specified by the user. Additionally, the commit modifies the display and parsing logic for `IggyExpiry` to use "never_expire" instead of "none" for clarity. The tests have been updated to reflect these changes, ensuring that the new defaults are correctly applied and tested. This closes #1536.
hubcio
added a commit
that referenced
this issue
Feb 17, 2025
This commit updates the CLI and associated tests to use "server_default" as the default value for max topic size and message expiry time, instead of "unlimited". This change ensures that the CLI uses the server's default configuration when parameters are not explicitly specified by the user. Additionally, the commit modifies the display and parsing logic for `IggyExpiry` to use "never_expire" instead of "none" for clarity. The tests have been updated to reflect these changes, ensuring that the new defaults are correctly applied and tested. This closes #1536.
hubcio
added a commit
that referenced
this issue
Feb 17, 2025
This commit updates the CLI and associated tests to use "server_default" as the default value for max topic size and message expiry time, instead of "unlimited". This change ensures that the CLI uses the server's default configuration when parameters are not explicitly specified by the user. Additionally, the commit modifies the display and parsing logic for `IggyExpiry` to use "never_expire" instead of "none" for clarity. The tests have been updated to reflect these changes, ensuring that the new defaults are correctly applied and tested. This closes #1536.
hubcio
added a commit
that referenced
this issue
Feb 17, 2025
This commit updates the CLI and associated tests to use "server_default" as the default value for max topic size and message expiry time, instead of "unlimited". This change ensures that the CLI uses the server's default configuration when parameters are not explicitly specified by the user. Additionally, the commit modifies the display and parsing logic for `IggyExpiry` to use "never_expire" instead of "none" for clarity. The tests have been updated to reflect these changes, ensuring that the new defaults are correctly applied and tested. This closes #1536.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm running iggy like this in docker-compose:
When I run these:
The message expiry is still unlimited:
The text was updated successfully, but these errors were encountered: