Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix toggling test fetch messages via timestamp #1323

Merged
merged 4 commits into from
Nov 4, 2024
Merged

Fix toggling test fetch messages via timestamp #1323

merged 4 commits into from
Nov 4, 2024

Conversation

hubcio
Copy link
Contributor

@hubcio hubcio commented Nov 3, 2024

Sometimes messages count is equal to 99, sometimes 100.
This commit adds a threshold that makes test stop toggling.

Sometimes messages count is equal to 99, sometimes 100.
This commit adds a threshold that makes test stop toggling.
@hubcio hubcio changed the title Fix toggling test: fetch messages via timestamp Fix toggling test fetch messages via timestamp Nov 3, 2024
@coveralls
Copy link

coveralls commented Nov 3, 2024

Pull Request Test Coverage Report for Build 11662873614

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.006%) to 75.119%

Files with Coverage Reduction New Missed Lines %
server/src/streaming/systems/messages.rs 1 69.7%
server/src/tcp/tcp_listener.rs 1 76.6%
server/src/configs/config_provider.rs 1 84.54%
Totals Coverage Status
Change from base Build 11662849231: 0.006%
Covered Lines: 23036
Relevant Lines: 30666

💛 - Coveralls

@hubcio hubcio merged commit cbc3232 into master Nov 4, 2024
17 checks passed
@hubcio hubcio deleted the fix_toggler branch November 4, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants