Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mimalloc allocator and adjust message save threshold #1492

Merged
merged 1 commit into from
Feb 8, 2025

Conversation

hubcio
Copy link
Contributor

@hubcio hubcio commented Feb 5, 2025

This commit integrates the mimalloc allocator as the default feature for
both the bench and server packages, aiming to improve memory allocation
performance. The messages_required_to_save configuration in
server.toml is reduced from 5000 to 1000 to enhance performance. by
Additionally, the server version is bumped from 0.4.151 to 0.4.152 to
reflect these changes.

numinnex
numinnex previously approved these changes Feb 5, 2025
@hubcio hubcio force-pushed the mimalloc-and-msgs-req-to-save branch 5 times, most recently from 9137306 to 97dd436 Compare February 5, 2025 18:39
spetz
spetz previously approved these changes Feb 5, 2025
@hubcio hubcio force-pushed the mimalloc-and-msgs-req-to-save branch from 97dd436 to 74b8078 Compare February 5, 2025 18:55
numinnex
numinnex previously approved these changes Feb 5, 2025
@coveralls
Copy link

coveralls commented Feb 5, 2025

Pull Request Test Coverage Report for Build 13215266574

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 30 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.09%) to 75.624%

Files with Coverage Reduction New Missed Lines %
server/src/streaming/batching/batch_accumulator.rs 14 69.14%
server/src/streaming/segments/messages.rs 16 64.0%
Totals Coverage Status
Change from base Build 13215044451: -0.09%
Covered Lines: 24956
Relevant Lines: 33000

💛 - Coveralls

@hubcio hubcio force-pushed the mimalloc-and-msgs-req-to-save branch 2 times, most recently from 9529562 to 3562675 Compare February 5, 2025 19:26
This commit integrates the mimalloc allocator as the default feature for
both the bench and server packages, aiming to improve memory allocation
performance. The messages_required_to_save configuration in
server.toml is reduced from 5000 to 1000 to enhance performance. by
Additionally, the server version is bumped from 0.4.151 to 0.4.152 to
reflect these changes.
@hubcio hubcio force-pushed the mimalloc-and-msgs-req-to-save branch from 3562675 to 4dfe05e Compare February 8, 2025 11:37
@hubcio hubcio merged commit 9956282 into master Feb 8, 2025
17 checks passed
@hubcio hubcio deleted the mimalloc-and-msgs-req-to-save branch February 8, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants