refactor(server): improve cache size calculation and memory tracking #1529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hubcio
force-pushed
the
improve-cache-size-calc
branch
from
1a4f2a1 to
00bdcf5
Compare
This commit refactors the cache size calculation by replacing the `LocalSizeable` trait with a new `RealSize` trait. The `RealSize` trait provides a more accurate calculation of the memory size of types, including overhead from containers like `Arc` and `Vec`.
hubcio
force-pushed
the
improve-cache-size-calc
branch
from
00bdcf5 to
e7d5e16
Compare
spetz
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refactors the cache size calculation by replacing the
LocalSizeabletrait with a newRealSizetrait. TheRealSizetrait provides a more accurate calculation of the memory size of
types, including overhead from containers like
ArcandVec.