fix golden file find

apache · Jan 24, 2024 · 1dc1f3d · 1dc1f3d
1 parent 67b2a9d
commit 1dc1f3d
Showing 1 changed file with 10 additions and 4 deletions.
diff --git a/backends-velox/src/test/scala/io/glutenproject/execution/VeloxTPCHSuite.scala b/backends-velox/src/test/scala/io/glutenproject/execution/VeloxTPCHSuite.scala
@@ -66,14 +66,20 @@ abstract class VeloxTPCHSuite extends VeloxTPCHTableSupport {
       .trim
   }
 
-  private def getGoldenFile(id: Int): String = {
-    val path = s"$rootPath/tpch-approved-plan/spark$formatSparkVersion/$id.txt"
-    formatMaterializedPlan(Source.fromFile(new File(path), "UTF-8").mkString)
+  private def getGoldenFile(path: String): String = {
+    val expect = Source.fromFile(new File(path), "UTF-8")
+    try {
+      formatMaterializedPlan(expect.mkString)
+    } finally {
+      expect.close()
+    }
   }
 
   private def checkGoldenFile(df: DataFrame, id: Int): Unit = {
+    val actual = formatMaterializedPlan(df.queryExecution.explainString(FormattedMode))
+    val path = s"$rootPath/tpch-approved-plan/spark$formatSparkVersion/$id.txt"
     assert(
-      getGoldenFile(id) == formatMaterializedPlan(df.queryExecution.explainString(FormattedMode)))
+      getGoldenFile(path) == actual, s"Current plan:\n$actual, find diff in golden file in $path")
   }
 
   test("TPC-H q1") {