[GLUTEN-4479][VL] Map unbase64 to a presto function

apache · Jan 23, 2024 · b63adf2 · b63adf2
1 parent a85f066
commit b63adf2
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 2 deletions.
diff --git a/backends-velox/src/test/scala/io/glutenproject/execution/VeloxFunctionsValidateSuite.scala b/backends-velox/src/test/scala/io/glutenproject/execution/VeloxFunctionsValidateSuite.scala
@@ -389,4 +389,10 @@ class VeloxFunctionsValidateSuite extends VeloxWholeStageTransformerSuite {
       checkOperatorMatch[ProjectExecTransformer]
     }
   }
+
+  test("Test unbase64 function") {
+    runQueryAndCompare("SELECT unbase64(l_comment) from lineitem limit 1") {
+      checkOperatorMatch[ProjectExecTransformer]
+    }
+  }
 }
diff --git a/cpp/velox/substrait/SubstraitParser.cc b/cpp/velox/substrait/SubstraitParser.cc
@@ -375,7 +375,8 @@ std::unordered_map<std::string, std::string> SubstraitParser::substraitVeloxFunc
     {"bit_and_merge", "bitwise_and_agg_merge"},
     {"murmur3hash", "hash_with_seed"},
     {"modulus", "mod"}, /*Presto functions.*/
-    {"date_format", "format_datetime"}};
+    {"date_format", "format_datetime"},
+    {"unbase64", "from_base64"}};
 
 const std::unordered_map<std::string, std::string> SubstraitParser::typeMap_ = {
     {"bool", "BOOLEAN"},

diff --git a/docs/velox-backend-support-progress.md b/docs/velox-backend-support-progress.md
@@ -183,7 +183,7 @@ Gluten supports 199 functions. (Draw to right to see all data types)
 | translate                     |                        |                       |        |                        |         |      |       |     |      |       |        |      |           |        |         |      |        |          |       |      |        |      |
 | trim                          | trim                   | trim                  | S      |                        |         |      |       |     |      |       |        |      |           | S      |         |      |        |          |       |      |        |      |
 | ucase, upper                  | upper                  | upper                 | S      |                        |         |      |       |     |      |       |        |      |           | S      |         |      |        |          |       |      |        |      |
-| unbase64                      |                        |                       |        |                        |         |      |       |     |      |       |        |      |           |        |         |      |        |          |       |      |        |      |
+| unbase64                      |                        |                       | S      |                        |         |      |       |     |      |       |        |      |           |        |         |      |        |          |       |      |        |      |
 | unhex                         |                        |                       |        |                        |         |      |       |     |      |       |        |      |           |        |         |      |        |          |       |      |        |      |
 | upper, ucase                  | upper                  | upper                 | S      |                        |         |      |       |     |      |       |        |      |           | S      |         |      |        |          |       |      |        |      |
 | xpath                         |                        |                       |        |                        |         |      |       |     |      |       |        |      |           |        |         |      |        |          |       |      |        |      |

diff --git a/gluten-core/src/main/scala/io/glutenproject/expression/ExpressionMappings.scala b/gluten-core/src/main/scala/io/glutenproject/expression/ExpressionMappings.scala
@@ -96,6 +96,7 @@ object ExpressionMappings {
     Sig[StringDecode](DECODE),
     Sig[Encode](ENCODE),
     Sig[Uuid](UUID),
+    Sig[UnBase64](UNBASE64),
 
     // URL functions
     Sig[ParseUrl](PARSE_URL),

diff --git a/shims/common/src/main/scala/io/glutenproject/expression/ExpressionNames.scala b/shims/common/src/main/scala/io/glutenproject/expression/ExpressionNames.scala
@@ -111,6 +111,7 @@ object ExpressionNames {
   final val DECODE = "decode"
   final val ENCODE = "encode"
   final val UUID = "uuid"
+  final val UNBASE64 = "unbase64"
 
   // URL functions
   final val PARSE_URL = "parse_url"