Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CMakeLists.txt to not compile useless libraries #2269

Merged
merged 4 commits into from
Jul 11, 2023

Conversation

zhanglistar
Copy link
Contributor

@zhanglistar zhanglistar commented Jul 10, 2023

Update CMakeLists.txt to not compile useless libraries

What changes were proposed in this pull request?

(Please fill in changes proposed in this fix)

(Fixes: #2248)

How was this patch tested?

(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
CI

(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
20% object less to compile

Update CMakeLists.txt to not compile useless libraries
@github-actions
Copy link

Run Gluten Clickhouse CI

@github-actions
Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@github-actions
Copy link

Run Gluten Clickhouse CI

@github-actions
Copy link

Run Gluten Clickhouse CI

@github-actions
Copy link

Run Gluten Clickhouse CI

Copy link
Contributor

@liuneng1994 liuneng1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@baibaichen baibaichen merged commit 4ae443e into apache:main Jul 11, 2023
jinchengchenghh pushed a commit to jinchengchenghh/gluten that referenced this pull request Jul 12, 2023
* Update CMakeLists.txt to not compile useless libraries

Update CMakeLists.txt to not compile useless libraries

* Update CMakeLists.txt

* Update CMakeLists.txt

* Update CMakeLists.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CH] libch.so too large needed to be reduced
3 participants