Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNM] test spark varbinary aggregate #2649

Conversation

gaoyangxiaozhu
Copy link
Contributor

@gaoyangxiaozhu gaoyangxiaozhu commented Aug 8, 2023

What changes were proposed in this pull request?

(Please fill in changes proposed in this fix)

(Fixes: #2169 )

How was this patch tested?

(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)

(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

@github-actions
Copy link

github-actions bot commented Aug 8, 2023

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@github-actions
Copy link

github-actions bot commented Aug 8, 2023

Run Gluten Clickhouse CI

@github-actions
Copy link

github-actions bot commented Aug 8, 2023

Run Gluten Clickhouse CI

1 similar comment
@github-actions
Copy link

github-actions bot commented Aug 8, 2023

Run Gluten Clickhouse CI

@github-actions
Copy link

github-actions bot commented Aug 8, 2023

Run Gluten Clickhouse CI

@zhejiangxiaomai
Copy link
Contributor

I restarted the failed workflow.

@zhouyuan
Copy link
Contributor

zhouyuan commented Aug 9, 2023

not sure why this failed on spark33 only

  test("SPARK-36726: test incorrect Parquet row group file offset") {
    readParquetFile(testFile("test-data/malformed-file-offset.parquet")) { df =>
      assert(df.count() == 3650)
    }
  }

@zhejiangxiaomai
Copy link
Contributor

"test incorrect Parquet row group file offset" failed twice. maybe you need fix it.

@github-actions
Copy link

github-actions bot commented Aug 9, 2023

Run Gluten Clickhouse CI

@gaoyangxiaozhu
Copy link
Contributor Author

gaoyangxiaozhu commented Aug 9, 2023

"test incorrect Parquet row group file offset" failed twice. maybe you need fix it.

hey @zhejiangxiaomai as synced offline with Zhouyuan, this a known issue and your team has send another PR https://github.com/oap-project/gluten/pull/2674/files to disable it since it already blocks other CH PRs check-in.

So it means the only fail is not related to my change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[VL] Failures need fix for UTs which are newly added in vanilla spark3.3
3 participants