[GLUTEN-3801][VL] Fix isAdaptiveContext null value for ColumnarOverrideRules #3795
Conversation
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/oap-project/gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
|
Run Gluten Clickhouse CI |
zhli1142015
changed the title
|
@rui-mo , @ulysses-you , @zhztheplayer , could you please help to review? For details please see #3801 |
| @@ -749,7 +751,8 @@ case class ColumnarOverrideRules(session: SparkSession) | |||
| private val aqeStackTraceIndex = 14 | |||
|
|
|||
| // Holds the original plan for possible entire fallback. | |||
| private val localOriginalPlan = new ThreadLocal[SparkPlan] | |||
| private val localOriginalPlans = new ThreadLocal[ListBuffer[SparkPlan]] | |||
| private val localIsAdaptiveContextFlags = new ThreadLocal[ListBuffer[Boolean]] | |||
There was a problem hiding this comment.
It's interesting.. Do you mean the columnarRule can be reentrant, Delta would apply columnarRule inside columnarRule ?
There was a problem hiding this comment.
Yes, from log, the delta log is loaded when applying columnarRules.
Details are listed in #3801
gluten-core/src/main/scala/io/glutenproject/extension/ColumnarOverrides.scala
Outdated
Show resolved
Hide resolved
|
Run Gluten Clickhouse CI |
|
it's better to add a ut for this issue ? |
|
Run Gluten Clickhouse CI |
Yes, added the failed case to delta ut. |
|
@ulysses-you , @zzcclp , @PHILO-HE , do you have any more commetns? |
|
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
Fixes: #3801
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)