Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] Update generic benchmark usage and doc #4485

Closed
wants to merge 3 commits into from

Conversation

marin-ma
Copy link
Contributor

@marin-ma marin-ma commented Jan 22, 2024

Follow-up of #4177

Main changes:

  • Removed the --skip-input flag for the first stage, and added --plan, --split and --data command line flags. --plan [path] to specify the plan file of Substrait JSON string. To simulate a first stage, similarly to how users obtain the Substrait JSON string, they need to extract the split JSON string from the executor log, save it to a separate file, and use --split [path] to specify the file. To simulate a middle stage, user need to specify the parquet file of inputs with --data [input_file_1] [input_file_2] ...
  • Refined the error log and documentation.

Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

Copy link

Run Gluten Clickhouse CI

Copy link

Run Gluten Clickhouse CI

Copy link

Run Gluten Clickhouse CI

@FelixYBW
Copy link
Contributor

what's the main change?

@marin-ma
Copy link
Contributor Author

what's the main change?

@FelixYBW Updated the PR description. Could you help to review? Thanks!

@marin-ma marin-ma closed this Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants