Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CORE] Fix ut module compilation with hadoop3.x #4490

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

Yohahaha
Copy link
Contributor

@Yohahaha Yohahaha commented Jan 23, 2024

mvn clean package -P backends-velox,spark-3.3,spark-ut,hadoop-3.2 -DskipTests

[ERROR] /root/oap-gluten/gluten-ut/spark33/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/GlutenParquetFilterSuite.scala:617: error: reference to In is ambiguous;
[ERROR] it is imported twice in the same scope by
[ERROR] import org.apache.parquet.filter2.predicate.Operators.{Column=>_, _}
[ERROR] and import org.apache.spark.sql.catalyst.expressions._
[ERROR]                           In(
[ERROR]                           ^
[ERROR] one error found
[ERROR] exception compilation error occurred!!!

Fix above compilation error and remove specified parquet-column dep, remove unnecessary arrow-version.

Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

Copy link

Run Gluten Clickhouse CI

ulysses-you
ulysses-you previously approved these changes Jan 23, 2024
@ulysses-you
Copy link
Contributor

it requires upgrade parquet version..

@Yohahaha
Copy link
Contributor Author

it requires upgrade parquet version..

I see, CI use -Phadoop2.7, I think we need set default profile to hadoop3 at least to align with Spark. I will open a issue for this.

Copy link

Run Gluten Clickhouse CI

@Yohahaha Yohahaha changed the title [CORE] Fix ut compliation [CORE] Fix ut module compilation and remove specified parquet-column dep Jan 23, 2024
Copy link

Run Gluten Clickhouse CI

1 similar comment
Copy link

Run Gluten Clickhouse CI

fix

remove unnecessary arrow.version

fix

fix
Copy link

Run Gluten Clickhouse CI

@zhztheplayer
Copy link
Member

zhztheplayer commented Jan 24, 2024

@Yohahaha LGTM. Would you like to add the Maven build command you used to produce this issue to PR description?

@Yohahaha
Copy link
Contributor Author

@Yohahaha LGTM. Would you like to add the Maven build command you used to produce this issue to PR description?

added, thanks!

@zhztheplayer
Copy link
Member

@Yohahaha LGTM. Would you like to add the Maven build command you used to produce this issue to PR description?

added, thanks!

Thanks. Why is the issue not failing CI?

@Yohahaha
Copy link
Contributor Author

Yohahaha commented Jan 24, 2024

@Yohahaha LGTM. Would you like to add the Maven build command you used to produce this issue to PR description?

added, thanks!

Thanks. Why is the issue not failing CI?

Due to this #4491, Gluten's default hadoop version is 2.7.

I see, CI use -Phadoop2.7, I think we need set default profile to hadoop3 at least to align with Spark. I will open a issue for this.

@ulysses-you ulysses-you changed the title [CORE] Fix ut module compilation and remove specified parquet-column dep [CORE] Fix ut module compilation with hadoop3.x Jan 24, 2024
@ulysses-you ulysses-you merged commit 1b34b2b into apache:main Jan 24, 2024
21 checks passed
@Yohahaha Yohahaha deleted the fix-ut-compile branch January 24, 2024 04:35
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_4490_time.csv log/native_master_01_23_2024_056512473_time.csv difference percentage
q1 33.49 33.97 0.486 101.45%
q2 23.89 23.91 0.018 100.07%
q3 38.53 36.73 -1.798 95.33%
q4 37.45 37.55 0.097 100.26%
q5 67.92 68.43 0.516 100.76%
q6 7.39 6.94 -0.453 93.87%
q7 82.51 81.76 -0.747 99.09%
q8 83.15 82.93 -0.217 99.74%
q9 123.76 116.13 -7.625 93.84%
q10 42.07 42.50 0.432 101.03%
q11 19.55 19.93 0.386 101.98%
q12 25.19 25.93 0.744 102.95%
q13 44.89 44.75 -0.132 99.71%
q14 15.17 19.50 4.331 128.56%
q15 28.76 30.82 2.059 107.16%
q16 14.19 13.93 -0.264 98.14%
q17 98.54 97.72 -0.821 99.17%
q18 146.83 148.73 1.893 101.29%
q19 15.28 12.44 -2.842 81.40%
q20 26.83 26.84 0.012 100.05%
q21 224.39 223.34 -1.057 99.53%
q22 13.64 13.33 -0.312 97.71%
total 1213.42 1208.13 -5.292 99.56%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants