Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] Clean up some legacy code for expression validation #4508

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

PHILO-HE
Copy link
Contributor

What changes were proposed in this pull request?

Clean up some legacy code for expression validation.

How was this patch tested?

Existing UT.

Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@PHILO-HE
Copy link
Contributor Author

@rui-mo

Copy link

Run Gluten Clickhouse CI

@PHILO-HE PHILO-HE merged commit 5ca4ed2 into apache:main Jan 25, 2024
18 of 19 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_4508_time.csv log/native_master_01_24_2024_7df896bf2_time.csv difference percentage
q1 34.86 31.79 -3.074 91.18%
q2 24.12 23.75 -0.373 98.45%
q3 37.69 37.77 0.076 100.20%
q4 37.31 37.98 0.676 101.81%
q5 68.64 66.72 -1.924 97.20%
q6 6.87 6.87 0.006 100.08%
q7 83.44 82.42 -1.017 98.78%
q8 85.01 83.45 -1.556 98.17%
q9 121.19 121.64 0.445 100.37%
q10 41.25 44.56 3.308 108.02%
q11 20.17 20.08 -0.091 99.55%
q12 26.67 28.81 2.145 108.04%
q13 45.72 44.54 -1.188 97.40%
q14 16.20 15.67 -0.527 96.75%
q15 27.31 27.54 0.235 100.86%
q16 13.95 14.10 0.145 101.04%
q17 99.29 99.75 0.460 100.46%
q18 146.13 144.42 -1.716 98.83%
q19 12.48 14.16 1.680 113.46%
q20 27.01 26.38 -0.636 97.65%
q21 222.01 224.22 2.211 101.00%
q22 13.43 13.45 0.021 100.16%
total 1210.74 1210.05 -0.693 99.94%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants