Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CORE] Add arch suffix for package jar #4529

Merged
merged 2 commits into from
Jan 30, 2024
Merged

Conversation

Yohahaha
Copy link
Contributor

@Yohahaha Yohahaha commented Jan 26, 2024

What changes were proposed in this pull request?

Add arch suffix for package jar and thridparty-lib.jar

See https://github.com/trustin/os-maven-plugin/blob/master/README.md#property-osdetectedarch

Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@Yohahaha
Copy link
Contributor Author

@PHILO-HE @zhouyuan could you help review this patch?

@PHILO-HE
Copy link
Contributor

cc @baibaichen @exmy

@ulysses-you
Copy link
Contributor

can we also add arch suffix for gluten-thirdparty-lib.jar and update related docs ?

@ulysses-you
Copy link
Contributor

I'm fine to add arch suffix. Leave this a while to see if any people have other comments.

@exmy
Copy link
Contributor

exmy commented Jan 29, 2024

LGTM

@PHILO-HE
Copy link
Contributor

@zhouyuan, assume we need to change package name in internal test accordingly.

Copy link
Contributor

@PHILO-HE PHILO-HE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@PHILO-HE PHILO-HE merged commit 4f9f2ae into apache:main Jan 30, 2024
18 checks passed
@Yohahaha Yohahaha deleted the add-arch-suffix branch January 30, 2024 01:53
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_4529_time.csv log/native_master_01_29_2024_f040fe8d6_time.csv difference percentage
q1 32.71 33.80 1.096 103.35%
q2 23.84 25.67 1.831 107.68%
q3 39.23 38.07 -1.158 97.05%
q4 37.60 40.59 2.985 107.94%
q5 70.21 69.30 -0.908 98.71%
q6 5.31 7.04 1.730 132.61%
q7 84.53 85.84 1.305 101.54%
q8 85.46 86.69 1.224 101.43%
q9 118.86 121.85 2.987 102.51%
q10 44.49 43.51 -0.975 97.81%
q11 20.05 19.98 -0.074 99.63%
q12 24.27 29.14 4.864 120.04%
q13 45.29 45.40 0.118 100.26%
q14 19.51 15.65 -3.852 80.25%
q15 28.96 29.66 0.698 102.41%
q16 14.34 14.28 -0.056 99.61%
q17 103.74 102.13 -1.610 98.45%
q18 147.16 149.99 2.835 101.93%
q19 12.52 13.92 1.401 111.18%
q20 25.95 26.90 0.954 103.67%
q21 225.14 225.67 0.535 100.24%
q22 13.47 13.48 0.018 100.14%
total 1222.62 1238.57 15.948 101.30%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants