-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CORE] Add arch suffix for package jar #4529
Conversation
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/oap-project/gluten/issues Then could you also rename commit message and pull request title in the following format?
See also: |
cc @baibaichen @exmy |
can we also add arch suffix for gluten-thirdparty-lib.jar and update related docs ? |
I'm fine to add arch suffix. Leave this a while to see if any people have other comments. |
LGTM |
@zhouyuan, assume we need to change package name in internal test accordingly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
What changes were proposed in this pull request?
Add arch suffix for package jar and thridparty-lib.jar
See https://github.com/trustin/os-maven-plugin/blob/master/README.md#property-osdetectedarch