-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VL] Put fmt lib back to vcpkg.json and bump the version #4557
Conversation
This reverts commit 6cdb55b.
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/oap-project/gluten/issues Then could you also rename commit message and pull request title in the following format?
See also: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
What changes were proposed in this pull request?
Add fmt lib back to vcpkg.json to let vcpkg build the static lib. In velox, fmt_SOURCE=AUTO, so the lib will be firstly searched from system. If not found, velox will build from SOURCE. With fmt managed by vcpkg, velox will directly use the pre-built lib found from vcpkg installation path. This pr also bumped the version to align with velox.
How was this patch tested?
Compile pass.