Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] Put fmt lib back to vcpkg.json and bump the version #4557

Merged
merged 2 commits into from
Jan 30, 2024

Conversation

PHILO-HE
Copy link
Contributor

@PHILO-HE PHILO-HE commented Jan 29, 2024

What changes were proposed in this pull request?

Add fmt lib back to vcpkg.json to let vcpkg build the static lib. In velox, fmt_SOURCE=AUTO, so the lib will be firstly searched from system. If not found, velox will build from SOURCE. With fmt managed by vcpkg, velox will directly use the pre-built lib found from vcpkg installation path. This pr also bumped the version to align with velox.

How was this patch tested?

Compile pass.

Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

Copy link
Contributor

@zhouyuan zhouyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PHILO-HE PHILO-HE changed the title [VL] Upgrade lib version managed by VCPKG [VL] Put fmt lib back to vcpkg.json and bump the version Jan 30, 2024
@PHILO-HE PHILO-HE marked this pull request as ready for review January 30, 2024 01:21
@PHILO-HE PHILO-HE merged commit d50c7a2 into apache:main Jan 30, 2024
20 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_4557_time.csv log/native_master_01_29_2024_f040fe8d6_time.csv difference percentage
q1 33.16 33.80 0.640 101.93%
q2 24.28 25.67 1.393 105.74%
q3 38.53 38.07 -0.460 98.81%
q4 38.21 40.59 2.371 106.21%
q5 69.21 69.30 0.089 100.13%
q6 7.06 7.04 -0.025 99.65%
q7 84.43 85.84 1.403 101.66%
q8 83.73 86.69 2.959 103.53%
q9 118.82 121.85 3.026 102.55%
q10 44.22 43.51 -0.705 98.41%
q11 19.80 19.98 0.181 100.91%
q12 29.15 29.14 -0.017 99.94%
q13 44.74 45.40 0.660 101.47%
q14 17.08 15.65 -1.424 91.66%
q15 28.53 29.66 1.126 103.95%
q16 14.20 14.28 0.076 100.54%
q17 102.81 102.13 -0.685 99.33%
q18 148.42 149.99 1.575 101.06%
q19 13.41 13.92 0.509 103.80%
q20 26.34 26.90 0.559 102.12%
q21 224.24 225.67 1.429 100.64%
q22 13.61 13.48 -0.121 99.11%
total 1224.01 1238.57 14.561 101.19%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants