[VL] Enable SPARK-10634 timestamp test case #5090
Conversation
liujiayi771
changed the title
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/apache/incubator-gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
|
Run Gluten Clickhouse CI |
| @@ -857,7 +857,6 @@ class VeloxTestSettings extends BackendTestSettings { | |||
| // decimal failed ut | |||
| .exclude("SPARK-34212 Parquet should read decimals correctly") | |||
| // Timestamp is read as INT96. | |||
| .exclude("SPARK-10634 timestamp written and read as INT64 - truncation") | |||
| .exclude("Migration from INT96 to TIMESTAMP_MICROS timestamp type") | |||
| .exclude("SPARK-10365 timestamp written and read as INT64 - TIMESTAMP_MICROS") | |||
There was a problem hiding this comment.
Have you tried above two unit tests, and are they related to the same issue?
| @@ -857,7 +857,6 @@ class VeloxTestSettings extends BackendTestSettings { | |||
| // decimal failed ut | |||
| .exclude("SPARK-34212 Parquet should read decimals correctly") | |||
| // Timestamp is read as INT96. | |||
There was a problem hiding this comment.
This message was added when int64 type was unsupported for timestamp reader. Could you update the message to illustrate why below tests are still disabled?
.exclude("Migration from INT96 to TIMESTAMP_MICROS timestamp type")
.exclude("SPARK-10365 timestamp written and read as INT64 - TIMESTAMP_MICROS")
There was a problem hiding this comment.
These two unit tests are still failing, but it's not the same issue. We can continue investigating to find the root cause.
|
Run Gluten Clickhouse CI |
liujiayi771
force-pushed
the
2024_03_22_ts_fix
branch
from
abaa255 to
b69e9aa
Compare
|
Run Gluten Clickhouse CI |
This reverts commit 0f3e72e.
|
Run Gluten Clickhouse CI |
What changes were proposed in this pull request?
Remove exclude for SPARK-10634 timestamp written and read as INT64 - truncation
How was this patch tested?
SPARK-10634 timestamp written and read as INT64 - truncation