Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] Upgrade folly to v2024.04.01.00 #5314

Merged
merged 8 commits into from
May 28, 2024
Merged

Conversation

PHILO-HE
Copy link
Contributor

@PHILO-HE PHILO-HE commented Apr 8, 2024

What changes were proposed in this pull request?

To align with Velox's change: facebookincubator/velox@5fed974.

If the patches under ports/ cannot be applied, no error is reported. So we need to manually apply the patches (uses the nearest version in vcpkg repo) to see the validity.

  • To fix the below build error caused by exception tracer module, we need to set -DFOLLY_NO_EXCEPTION_TRACER=ON.
(.text.__cxa_begin_catch+0x0): multiple definition of `__cxa_begin_catch'
/usr/local/lib/libfolly.a(ExceptionTracerLib.cpp.o):/tmp/build/folly/folly/experimental/exception_tracer/ExceptionTracerLib.cpp:123: first defined here

How was this patch tested?

Existing tests.

Copy link

github-actions bot commented Apr 8, 2024

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@zhouyuan zhouyuan marked this pull request as ready for review May 22, 2024 04:17
@zhouyuan
Copy link
Contributor

@PHILO-HE It looks like this patch is missed

@PHILO-HE PHILO-HE merged commit c20437a into apache:main May 28, 2024
38 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_5314_time.csv log/native_master_05_27_2024_efd6f31fb_time.csv difference percentage
q1 33.76 34.01 0.255 100.76%
q2 23.63 25.69 2.062 108.73%
q3 36.47 36.59 0.124 100.34%
q4 30.83 34.28 3.451 111.19%
q5 68.74 70.33 1.587 102.31%
q6 7.49 7.60 0.108 101.44%
q7 80.33 82.15 1.819 102.26%
q8 85.98 88.29 2.305 102.68%
q9 119.70 122.17 2.474 102.07%
q10 45.95 46.70 0.745 101.62%
q11 20.54 20.07 -0.463 97.74%
q12 28.14 23.62 -4.521 83.94%
q13 52.00 53.35 1.349 102.59%
q14 17.92 17.13 -0.791 95.58%
q15 29.93 31.65 1.719 105.74%
q16 13.92 13.86 -0.054 99.61%
q17 104.77 103.47 -1.301 98.76%
q18 144.81 144.12 -0.689 99.52%
q19 16.28 13.72 -2.566 84.24%
q20 26.90 28.10 1.196 104.45%
q21 259.32 260.32 1.008 100.39%
q22 12.04 12.53 0.483 104.01%
total 1259.46 1269.76 10.300 100.82%

@PHILO-HE PHILO-HE deleted the upgrade-folly branch October 24, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants