Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-7362][VL] Add test for 'IN' and 'OR' filter in Scan #7363

Merged
merged 1 commit into from
Nov 14, 2024
Merged

[GLUTEN-7362][VL] Add test for 'IN' and 'OR' filter in Scan #7363

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions backends-velox/src/test/scala/org/apache/gluten/execution/MiscOperatorSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,13 @@ class MiscOperatorSuite extends VeloxWholeStageTransformerSuite with AdaptiveSpa
"select l_orderkey from lineitem " +
"where l_partkey in (1552, 674) or l_partkey in (1552) and l_orderkey > 1") { _ => }
checkLengthAndPlan(df, 73)

runQueryAndCompare(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have merged d6326f0. Would you like to try if this issue has been fixed? Perhaps we can merge this test to ensure the functionality. Thanks for your patience.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I will try it locally later.

"select count(1) from lineitem " +
"where (l_shipmode in ('TRUCK', 'MAIL') or l_shipmode in ('AIR', 'FOB')) " +
"and l_shipmode in ('RAIL','SHIP')") {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this issue is in the condition (A or B) and C, when C is already pushed down, the (A or B) cannot be pushed down.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but only for in, which is singularOrList.

checkGlutenOperatorMatch[FileSourceScanExecTransformer]
}
}

test("in_not") {
Expand Down
Loading