-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GLUTEN-8581][VL] Fix Spark legacy date formatter under case insensitive configuration #8583
Conversation
Run Gluten Clickhouse CI on x86 |
1f05a5a
to
c4c1e99
Compare
Run Gluten Clickhouse CI on x86 |
c4c1e99
to
e6e1039
Compare
Run Gluten Clickhouse CI on x86 |
…rk.sql.legacy.timeParserPolicy is set to LEGACY or legacy.
e6e1039
to
a84c127
Compare
Run Gluten Clickhouse CI on x86 |
e7079e6
to
daff06f
Compare
Run Gluten Clickhouse CI on x86 |
1 similar comment
Run Gluten Clickhouse CI on x86 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two comments. Thank you!
gluten-ut/spark35/src/test/scala/org/apache/spark/sql/GlutenDateFunctionsSuite.scala
Outdated
Show resolved
Hide resolved
Run Gluten Clickhouse CI on x86 |
02ff850
to
5500591
Compare
Run Gluten Clickhouse CI on x86 |
5500591
to
7e1d7cb
Compare
Run Gluten Clickhouse CI on x86 |
gluten-ut/spark32/src/test/scala/org/apache/spark/sql/GlutenDateFunctionsSuite.scala
Outdated
Show resolved
Hide resolved
gluten-ut/spark33/src/test/scala/org/apache/spark/sql/GlutenDateFunctionsSuite.scala
Outdated
Show resolved
Hide resolved
gluten-ut/spark34/src/test/scala/org/apache/spark/sql/GlutenDateFunctionsSuite.scala
Outdated
Show resolved
Hide resolved
gluten-ut/spark35/src/test/scala/org/apache/spark/sql/GlutenDateFunctionsSuite.scala
Outdated
Show resolved
Hide resolved
Run Gluten Clickhouse CI on x86 |
7266254
to
50fc3c4
Compare
Run Gluten Clickhouse CI on x86 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
===== Performance report for TPCDS SF2000 with Velox backend, for reference only ====
|
…ive configuration (apache#8583)
What changes were proposed in this pull request?
The #7375 has enabled Velox simple date time formatter if the
spark.sql.legacy.timeParserPolicy
is set toLEGACY
. But, it doesn't work when thespark.sql.legacy.timeParserPolicy
is set tolegacy
.(Fixes: #8581)
How was this patch tested?
Add unittests.