Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-8761][VL] Fix mode in UnsafeColumnarBuildSideRelation not get properly serialize #8762

Merged
merged 3 commits into from
Feb 20, 2025

Conversation

zjuwangg
Copy link
Contributor

What changes were proposed in this pull request?

Fix mode field in UnsafeColumnarBuildSideRelation can not get properly serialized and deserialized, also fix when using Java default serializer potential data mismatch by change read to readFully.

(Fixes: #8761)

How was this patch tested?

(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
unit test

@github-actions github-actions bot added the VELOX label Feb 18, 2025
Copy link

#8761

Copy link
Member

@zhztheplayer zhztheplayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zjuwangg Was there any visible error before this fix?

@zjuwangg
Copy link
Contributor Author

@zjuwangg Was there any visible error before this fix?

There will be a error like following in distributed than local test.

An exception or error caused a run to abort: org.apache.spark.sql.catalyst.plans.physical.BroadcastMode
java.lang.InstantiationError: org.apache.spark.sql.catalyst.plans.physical.BroadcastMode
at sun.reflect.GeneratedSerializationConstructorAccessor36.newInstance(Unknown Source)
at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
at org.objenesis.instantiator.sun.SunReflectionFactoryInstantiator.newInstance(SunReflectionFactoryInstantiator.java:48)
at com.esotericsoftware.kryo.Kryo.newInstance(Kryo.java:1139)
at com.esotericsoftware.kryo.serializers.FieldSerializer.create(FieldSerializer.java:562)
at com.esotericsoftware.kryo.serializers.FieldSerializer.read(FieldSerializer.java:538)
at com.esotericsoftware.kryo.Kryo.readObject(Kryo.java:709)
at org.apache.spark.sql.execution.unsafe.UnsafeColumnarBuildSideRelation.$anonfun$read$1(UnsafeColumnarBuildSideRelation.scala:148)

Local test not get failed I guess it's because executor and driver share same process and thus the deserialization not get called actually.

@zhztheplayer zhztheplayer changed the title [GLUTEN-8761][VL]Fix mode in UnsafeColumnarBuildSideRelation not get properly serialize [GLUTEN-8761][VL] Fix mode in UnsafeColumnarBuildSideRelation not get properly serialize Feb 19, 2025
@zhztheplayer zhztheplayer merged commit 4e5b7a2 into apache:main Feb 20, 2025
50 checks passed
@zjuwangg zjuwangg deleted the m_fixModeSerializa branch February 20, 2025 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[VL]when using UnsafeColumnarBuildSideRelation, mode can not get correctly deserialize
3 participants