Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] Skip PartialProjectRule if spark.gluten.sql.columnar.partial.project is false #8773

Merged
merged 1 commit into from
Feb 19, 2025
+4 −3
Merged

[VL] Skip PartialProjectRule if spark.gluten.sql.columnar.partial.project is false #8773

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions backends-velox/src/main/scala/org/apache/gluten/execution/ColumnarPartialProjectExec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,9 +147,6 @@ case class ColumnarPartialProjectExec(original: ProjectExec, child: SparkPlan)(
}

override protected def doValidateInternal(): ValidationResult = {
if (!GlutenConfig.get.enableColumnarPartialProject) {
return ValidationResult.failed("Config disable this feature")
}
if (UDFAttrNotExists) {
return ValidationResult.failed("Attribute in the UDF does not exists in its child")
}
Expand Down
4 changes: 4 additions & 0 deletions backends-velox/src/main/scala/org/apache/gluten/extension/PartialProjectRule.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
*/
package org.apache.gluten.extension

import org.apache.gluten.config.GlutenConfig
import org.apache.gluten.execution.ColumnarPartialProjectExec

import org.apache.spark.sql.SparkSession
Expand All @@ -24,6 +25,9 @@ import org.apache.spark.sql.execution.{ProjectExec, SparkPlan}

case class PartialProjectRule(spark: SparkSession) extends Rule[SparkPlan] {
override def apply(plan: SparkPlan): SparkPlan = {
if (!GlutenConfig.get.enableColumnarPartialProject) {
return plan
}
plan.transformUp {
case plan: ProjectExec =>
val transformer = ColumnarPartialProjectExec.create(plan)
Expand Down
Loading