Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat][Java] Fill two incompatible gaps between C++ and Java #279

Merged
merged 19 commits into from
Nov 14, 2023

Conversation

Thespica
Copy link
Contributor

Proposed changes

  • Use inherit to implement EdgesCollection
  • Add internal id column to vertex payload file

Types of changes

What types of changes does your code introduce to GraphAr?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Related issue: #272

@Thespica Thespica changed the title [Feat][Java] Fill two incompatible gap between C++ and Java [Feat][Java] Fill two incompatible gaps between C++ and Java Nov 11, 2023
@acezen acezen self-requested a review November 12, 2023 05:44
@@ -51,9 +50,19 @@ jobs:
mvn spotless:check
popd

- name: Build and Install cpp
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can change the gar version to v0.10.0, https://github.com/alibaba/GraphAr/blob/77f547ac14a786b6f557456cec3bb17e19256602/java/cmake/graphar-cpp.cmake#L51

no need to install latest cpp, it may make cpp update break the java ci

Copy link
Contributor

@acezen acezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acezen
Copy link
Contributor

acezen commented Nov 14, 2023

@Thespica Great Work!

@acezen acezen merged commit 5330e93 into apache:main Nov 14, 2023
@acezen acezen added this to the Release v0.11.0 milestone Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants