-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat][Java] Fill two incompatible gaps between C++ and Java #279
Conversation
.github/workflows/java.yml
Outdated
@@ -51,9 +50,19 @@ jobs: | |||
mvn spotless:check | |||
popd | |||
|
|||
- name: Build and Install cpp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can change the gar version to v0.10.0, https://github.com/alibaba/GraphAr/blob/77f547ac14a786b6f557456cec3bb17e19256602/java/cmake/graphar-cpp.cmake#L51
no need to install latest cpp, it may make cpp update break the java ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Thespica Great Work! |
Proposed changes
Types of changes
What types of changes does your code introduce to GraphAr?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
Related issue: #272