Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve][Java] Get test resources form environment variables, and remove all print sentences #309

Merged
merged 5 commits into from
Dec 29, 2023

Conversation

Thespica
Copy link
Contributor

Get test resources form environment variables, and remove all print sentences

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

close #308 .

Copy link
Contributor

@acezen acezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acezen
Copy link
Contributor

acezen commented Dec 29, 2023

hi, @Thespica, does the pr ready to merge?

@Thespica
Copy link
Contributor Author

@acezen Yes, ready to merge

@acezen acezen merged commit 730004f into apache:main Dec 29, 2023
3 checks passed
@Thespica Thespica deleted the java-test-from-env branch December 29, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat][Java] Get test resources form environment variables, and remove all print sentences.
2 participants