Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix][C++] Fix bug: PropertyGroup with empty properties make VertexInfo/EdgeInfo dumps failed #393

Merged
merged 4 commits into from
Mar 8, 2024

Conversation

acezen
Copy link
Contributor

@acezen acezen commented Mar 7, 2024

Proposed changes

This change aims to fix that PropertyGroup with empty properties bug

  • Not allow create property group with empty properties, if so, it's invalid;
  • Not allow create edge info with empty adj list vector, if so, it's invalid;
  • Not allow empty label name and chunk_size <= when create VertexInfo/EdgeInfo
  • Add try.. catch.. to catch exception in Dump methods.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

close #392

@acezen acezen requested review from Thespica and lixueclaire March 7, 2024 12:23
Copy link
Contributor

@lixueclaire lixueclaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acezen acezen merged commit da86711 into apache:main Mar 8, 2024
4 checks passed
@acezen acezen deleted the 392-fix-dumps-error branch March 8, 2024 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug][C++]: Add PropertyGroup with empty property vector would make VertexInfo/EdgeInfo dump failed
2 participants