-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initialize the spark tool of GraphAr and implement the Info and IndexGenerator #45
Conversation
@lixueclaire any review comments? |
I think "GetDirPath" (for VertexInfo) and "GetAdjListDirPath"/"GetAdjListOffsetDirPath"/"GetPropertyDirPath" (for EdgeInfo) could be added for aligning with C++ SDK |
The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks ready for merging~
return false | ||
} | ||
|
||
def containProperty(property_name: String): Boolean = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if "adj_list_type" is necessary as a input parameter for this function, also consider the functions:
def getPropertyType(property_name: String): GarType.Value
def isPrimaryKey(property_name: String): Boolean
def getPrimaryKey(): String
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
emm, you are right. adj_list_type
should be include in these functions and the c++ Info class also need to updated.
This pull request can aligned to c++ at first and I will open an issue for these change and solved it as soon as possible.
Proposed changes
These changes initialize the code base of GraphAr spark tool and implement the Info classes for spark tool.
Types of changes
What types of changes does your code introduce to GraphAr?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
Fixed issue #32