-
Notifications
You must be signed in to change notification settings - Fork 594
Conversation
Looks good, thanks for doing this. Would you also please verify this branch in twitter's internal CI. |
@objmagic - can you check with our internal version as @billonahill pointed out so that we can merge this? |
👍 |
@kramasamy yes |
One more think to check is to make sure the docker builds work. Once that's verified I think it's fine to merge. |
Internal CI passed. I can also build and run on Docker following steps here. I'll go ahead to merge it if everyone think it's fine. |
👍 for internal jenkins CI |
@benley do you want to have a look at this PR? |
👍 |
I think you might be missing some updates to pex/bin/pex.py; here's what that diff looks like from my repo: https://github.com/benley/bazel_rules_pex/pull/6/files#diff-da6b827279fc47e8b1603fe3af0f4a0e The changes are pretty minor, so maybe you deliberately didn't include them? |
Aside from that, 👍 |
upgrade to 1.1.11.
Travis CI, internal CI, Docker build all passed, again. |
resolves #1051
In this PR, I will restart CI many times to see if the same error will happen again...