Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(store): integrate store-rocksdb submodule #2513

Merged
merged 5 commits into from
Apr 19, 2024

Conversation

Pengzna
Copy link
Contributor

@Pengzna Pengzna commented Apr 9, 2024

Subtask of #2265 and #2482

The corresponding tests will be merged after store-core and store-node

Detailed doc can be seen in this link

@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. feature New feature rocksdb RocksDB backend labels Apr 9, 2024
@VGalaxies VGalaxies requested review from VGalaxies and imbajin April 9, 2024 03:53
@VGalaxies VGalaxies added the store Store module label Apr 9, 2024
@imbajin imbajin added this to the 1.5.0 milestone Apr 9, 2024
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why we need this empty file?

Copy link
Contributor Author

@Pengzna Pengzna Apr 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why we need this empty file?

@imbajin Don’t know what the use of this file is. Ignore it for now and wait for confirmation before processing it.

hugegraph-store/hg-store-rocksdb/pom.xml Outdated Show resolved Hide resolved
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 18, 2024
@imbajin imbajin self-requested a review April 18, 2024 15:42
@VGalaxies VGalaxies merged commit b4bc1f0 into apache:master Apr 19, 2024
14 checks passed
@VGalaxies VGalaxies changed the title feat(store): integrate store-rocksdb into Hugegraph feat(store): integrate store-rocksdb submodule Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature lgtm This PR has been approved by a maintainer rocksdb RocksDB backend size:XXL This PR changes 1000+ lines, ignoring generated files. store Store module
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants