[incubator-kie-issues#1370] DMN: refactor BaseFEELFunction getCandidateMethod #6023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
June 28, 2024 09:04
… not covered. Issues with singleton list of null element
|
TCK tests passed successfully, well done! |
yesamer
approved these changes
Jul 15, 2024
yesamer
reviewed
Jul 15, 2024
| @@ -6,9 +6,9 @@ | |||
| * to you under the Apache License, Version 2.0 (the | |||
| * "License"); you may not use this file except in compliance | |||
| * with the License. You may obtain a copy of the License at | |||
| * | |||
| * <p> | |||
baldimir
reviewed
Jul 16, 2024
| if ( isNamedParams ) { | ||
| params = rearrangeParameters(params, this.getParameters().get(0).stream().map(Param::getName).collect(Collectors.toList())); | ||
| if (isNamedParams) { | ||
| // This is inherently frail because it expects that, if, the first parameter is NamedParameter |
There was a problem hiding this comment.
I think as far as I understand it, this is by the specification. Please see section 10.3.1.2 Grammar rules, Rule 39 in the specification. The "parameters" are either "named parameters" or "positional parameters".
baldimir
reviewed
Jul 16, 2024
| Object[] toReturn = addCtxParamIfRequired(ctx, params, isNamedParams, m); | ||
| Class<?>[] parameterTypes = m.getParameterTypes(); | ||
| if (isNamedParams) { | ||
| // This is inherently frail because it expects that, if, the first parameter is NamedParameter and the |
There was a problem hiding this comment.
I think as far as I understand it, this is by the specification. Please see section 10.3.1.2 Grammar rules, Rule 39 in the specification. The "parameters" are either "named parameters" or "positional parameters".
baldimir
approved these changes
Jul 16, 2024
|
Do we know the performance impact of this please? |
|
Main 1370 |
|
@baldimir @yesamer @mariofusco 1370 Now the differences seems more negligible and, in few cases, it seems new code is faster |
mariofusco
approved these changes
Jul 17, 2024
rgdoliveira
pushed a commit
to rgdoliveira/drools
that referenced
this pull request
Jul 17, 2024
…teMethod (apache#6023) * [incubator-kie-issues#1370] Clean up signature/unused code * [incubator-kie-issues#1370] WIP. Implemented first unit test * [incubator-kie-issues#1370] WIP. Implemented unit tests * [incubator-kie-issues#1370] WIP. Further refactoring with unit tests. Fully working * [incubator-kie-issues#1370] WIP. Begin ScorerHelper implementation. Fully working * [incubator-kie-issues#1370] WIP. Implemented ScorerHelper with test. Fully working * [incubator-kie-issues#1370] WIP. TODO: fix score logic - corner cases not covered. Issues with singleton list of null element * [incubator-kie-issues#1370] Working. Implemented tests. * [incubator-kie-issues#1370] Fully working. Fixing corner cases with Object parameters * [incubator-kie-issues#1370] Implemented CustomFunction invocation test * [incubator-kie-issues#1370] Improvement based on PR suggestion * [incubator-kie-issues#1370] Fix formatting * [incubator-kie-issues#1370] Benchmark improving - refactoring --------- Co-authored-by: Gabriele-Cardosi <[email protected]>
rodrigonull
pushed a commit
to rodrigonull/incubator-kie-drools
that referenced
this pull request
Oct 7, 2024
…teMethod (apache#6023) * [incubator-kie-issues#1370] Clean up signature/unused code * [incubator-kie-issues#1370] WIP. Implemented first unit test * [incubator-kie-issues#1370] WIP. Implemented unit tests * [incubator-kie-issues#1370] WIP. Further refactoring with unit tests. Fully working * [incubator-kie-issues#1370] WIP. Begin ScorerHelper implementation. Fully working * [incubator-kie-issues#1370] WIP. Implemented ScorerHelper with test. Fully working * [incubator-kie-issues#1370] WIP. TODO: fix score logic - corner cases not covered. Issues with singleton list of null element * [incubator-kie-issues#1370] Working. Implemented tests. * [incubator-kie-issues#1370] Fully working. Fixing corner cases with Object parameters * [incubator-kie-issues#1370] Implemented CustomFunction invocation test * [incubator-kie-issues#1370] Improvement based on PR suggestion * [incubator-kie-issues#1370] Fix formatting * [incubator-kie-issues#1370] Benchmark improving - refactoring --------- Co-authored-by: Gabriele-Cardosi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes apache/incubator-kie-issues#1370
How to replicate CI configuration locally?
Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.
build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.
How to retest this PR or trigger a specific build:
for pull request and downstream checks
for a full downstream build
run_fdbfor Jenkins PR check only
Build Nowbutton.