-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1710 - library still present and requires LICENSE file update #6196
Conversation
Hi @porcelli , apache/incubator-kie-issues#1710 (comment)
I think we don't need to bring back the license statement. We'd like to: A) Automate WDYT? |
Not approving, waiting for response to @tkobayas comment. That was my understanding, that it is not needed as |
my perspective is that, planned to be removed during release is a temporary solution.. and we have to make sure that we won't overlook it... and to be honest.. the violation is in this repository and should be documented. actually the real release LICENSE file even ignores this file... but we have it - as based on Apache policies - to have in every repository the LICENSE reflecting the codebase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that we will eventually fix the license problem in drools-docs
, so approved this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for detailed explanation @porcelli
…pache#6196) * apache#1710 - library still present and requires LICENSE file update * Update LICENSE --------- Co-authored-by: Toshiya Kobayashi <[email protected]>
Related: apache/incubator-kie-issues#1710