Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1710 - library still present and requires LICENSE file update #6196

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

porcelli
Copy link
Member

@porcelli porcelli requested review from tkobayas and jomarko December 12, 2024 20:47
@tkobayas
Copy link
Contributor

tkobayas commented Dec 13, 2024

Hi @porcelli ,

apache/incubator-kie-issues#1710 (comment)

drools-docs is not a part of the software, so the plan is to exclude it from the source distribution on subsequent releases, I thought. We removed it in 10.0.x branch manually, but we would be able to automate it with CI. Isn't it the goal of this GH issue?

I think we don't need to bring back the license statement.

We'd like to:

A) Automate drools-docs exclusion in setup-branch CI for release
B) If A is not implemented yet for the next release, we would manually remove it like we did for 10.0.x

WDYT?

@jomarko
Copy link
Contributor

jomarko commented Dec 13, 2024

Not approving, waiting for response to @tkobayas comment. That was my understanding, that it is not needed as drools-docs will be not part of the sources release.

@porcelli
Copy link
Member Author

my perspective is that, planned to be removed during release is a temporary solution.. and we have to make sure that we won't overlook it... and to be honest.. the violation is in this repository and should be documented.

actually the real release LICENSE file even ignores this file... but we have it - as based on Apache policies - to have in every repository the LICENSE reflecting the codebase

LICENSE Show resolved Hide resolved
Copy link
Contributor

@tkobayas tkobayas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that we will eventually fix the license problem in drools-docs, so approved this PR.

Copy link
Contributor

@jomarko jomarko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for detailed explanation @porcelli

@porcelli porcelli merged commit cd6f510 into apache:main Dec 16, 2024
1 check passed
rgdoliveira pushed a commit to rgdoliveira/drools that referenced this pull request Dec 17, 2024
…pache#6196)

* apache#1710 - library still present and requires LICENSE file update

* Update LICENSE

---------

Co-authored-by: Toshiya Kobayashi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants