Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10.0.x forwarder of LICENSE and script adjustments + license adjustments for LEGAL-691 #1271

Merged
merged 3 commits into from
Jan 6, 2025

Conversation

porcelli
Copy link
Member

@porcelli porcelli commented Dec 12, 2024

Copy link
Contributor

@jomarko jomarko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR, don't we need to add alos these drools LICENSE entries?

  • drools-drl/drools-drl-parser/src/main/antlr4/org/drools/drl/parser/antlr4/JavaLexer.g4
  • drools-drl/drools-drl-parser/src/main/antlr4/org/drools/drl/parser/antlr4/JavaParser.g4
  • drools-model/drools-mvel-parser/src/main/javacc/mvel.jj
  • drools-util/src/main/java/org/drools/util/StringUtils.java
  • *pmml*

Comment on lines +203 to +213
------------------------------------------------------------------------------------
for incubator-kie-drools/drools-decisiontables/src/main/java/org/drools/decisiontable/parser/csv/CsvLineParser.java

Inner logic adapted from a C++ original that was Copyright (C) 1999
Lucent Technologies Excerpted from 'The Practice of Programming' by Brian
Kernighan and Rob Pike.

Included by permission of the http://tpop.awl.com/ web site, which says:
"You may use this code for any purpose, as long as you leave the
copyright notice and book citation attached."

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably we should merge first this PR:
apache/incubator-kie-drools#6195

then we can probably drop highlighted lines from #1271

@tkobayas
Copy link
Contributor

Thank you for the PR, don't we need to add alos these drools LICENSE entries?

* drools-drl/drools-drl-parser/src/main/antlr4/org/drools/drl/parser/antlr4/JavaLexer.g4

* drools-drl/drools-drl-parser/src/main/antlr4/org/drools/drl/parser/antlr4/JavaParser.g4

* drools-model/drools-mvel-parser/src/main/javacc/mvel.jj

* drools-util/src/main/java/org/drools/util/StringUtils.java

* _pmml_

Thank you for the points, @jomarko . I think it's better to combine License files in main branch than backporting 10.0.x

@jomarko
Copy link
Contributor

jomarko commented Dec 13, 2024

Thank you for the PR, don't we need to add alos these drools LICENSE entries?

* drools-drl/drools-drl-parser/src/main/antlr4/org/drools/drl/parser/antlr4/JavaLexer.g4

* drools-drl/drools-drl-parser/src/main/antlr4/org/drools/drl/parser/antlr4/JavaParser.g4

* drools-model/drools-mvel-parser/src/main/javacc/mvel.jj

* drools-util/src/main/java/org/drools/util/StringUtils.java

* _pmml_

Thank you for the points, @jomarko . I think it's better to combine License files in main branch than backporting 10.0.x

Not sure I follow @tkobayas . You say should we or we should not add those entries ?

@tkobayas
Copy link
Contributor

@jomarko , I mean we should add the entries.

Those entries are missed in this PR because Alex tries to backport the 10.0.x LICENSE file. But they exist in the main LICENSE. We maintain LICENSE files in main of kie repos, so combining them would naturally result in a valid single LICENSE for root. Does it make sense? @jomarko @porcelli

@porcelli
Copy link
Member Author

correct @tkobayas! @jomarko my recommendation is to bring these files as is.. and we improve those after merge.

note that in this backport (actually forwardport) it also brings the script that adjusts the source zip

@tkobayas
Copy link
Contributor

and we improve those after merge.

Yeah, we can improve it with a new PR after merge. It's good to merge this.

@jomarko
Copy link
Contributor

jomarko commented Dec 16, 2024

Could you please share a ticket, epic, whatever where we track this plan for a future fixes?

@porcelli porcelli changed the title 10.0.x backport of LICENSE and script adjustments + license adjustments for LEGAL-691 10.0.x forwarder of LICENSE and script adjustments + license adjustments for LEGAL-691 Dec 16, 2024
@porcelli
Copy link
Member Author

porcelli commented Jan 5, 2025

Copy link
Contributor

@jomarko jomarko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for sharing link for the ticket @porcelli

@porcelli porcelli merged commit c2c5e0e into apache:main Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants