-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
10.0.x forwarder of LICENSE and script adjustments + license adjustments for LEGAL-691 #1271
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR, don't we need to add alos these drools LICENSE entries?
- drools-drl/drools-drl-parser/src/main/antlr4/org/drools/drl/parser/antlr4/JavaLexer.g4
- drools-drl/drools-drl-parser/src/main/antlr4/org/drools/drl/parser/antlr4/JavaParser.g4
- drools-model/drools-mvel-parser/src/main/javacc/mvel.jj
- drools-util/src/main/java/org/drools/util/StringUtils.java
- *pmml*
------------------------------------------------------------------------------------ | ||
for incubator-kie-drools/drools-decisiontables/src/main/java/org/drools/decisiontable/parser/csv/CsvLineParser.java | ||
|
||
Inner logic adapted from a C++ original that was Copyright (C) 1999 | ||
Lucent Technologies Excerpted from 'The Practice of Programming' by Brian | ||
Kernighan and Rob Pike. | ||
|
||
Included by permission of the http://tpop.awl.com/ web site, which says: | ||
"You may use this code for any purpose, as long as you leave the | ||
copyright notice and book citation attached." | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably we should merge first this PR:
apache/incubator-kie-drools#6195
then we can probably drop highlighted lines from #1271
Thank you for the points, @jomarko . I think it's better to combine License files in main branch than backporting 10.0.x |
Not sure I follow @tkobayas . You say should we or we should not add those entries ? |
@jomarko , I mean we should add the entries. Those entries are missed in this PR because Alex tries to backport the 10.0.x |
Yeah, we can improve it with a new PR after merge. It's good to merge this. |
Could you please share a ticket, epic, whatever where we track this plan for a future fixes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for sharing link for the ticket @porcelli
Related: apache/incubator-kie-tools#2799