Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[incubator-kie-issues#1775] Springboot apps - Conditionally overwrite code-related context properties only if twin system properties are not null #3832

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

gitgabrio
Copy link
Contributor

Fixes apache/incubator-kie-issues#1775

This PR:

  1. overwrite the code-gen context properties only if related system properties are not null/empty
  2. unit test newly added methods/checks
How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

…ext properties only if twin system properties are not null
Copy link
Contributor

@yesamer yesamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gitgabrio Thank you for the fix and adding the Unit Tests. So, with this change, we are now saying the code-gen MUST be explicitly enabled, otherwise is disabled by default. Is this change consistent with all the examples/documentation we have?

@gitgabrio
Copy link
Contributor Author

@yesamer
code-gen is already enabled by default (see here). This fix allows user to disable it on demand.

@gitgabrio gitgabrio merged commit e67e359 into apache:main Jan 23, 2025
6 of 7 checks passed
@gitgabrio gitgabrio deleted the incubator-kie-issues#1775 branch January 23, 2025 10:31
rgdoliveira pushed a commit to rgdoliveira/kogito-runtimes that referenced this pull request Jan 27, 2025
…ext properties only if twin system properties are not null (apache#3832)

Co-authored-by: Gabriele-Cardosi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kogito.codegen.* properties ignored in springboot applications
4 participants